chore: remove TODOs

This commit is contained in:
Leonardo de Moura 2024-01-29 18:36:52 -08:00 committed by Scott Morrison
parent 8deb1838aa
commit 168217b2bd
4 changed files with 4 additions and 8 deletions

View file

@ -63,8 +63,7 @@ builtin_simproc [simp, seval] reduceGT (( _ : Fin _) > _) := reduceBinPred ``G
builtin_simproc [simp, seval] reduceGE (( _ : Fin _) ≥ _) := reduceBinPred ``GE.ge 4 (. ≥ .)
/-- Return `.done` for Fin values. We don't want to unfold in the symbolic evaluator. -/
-- TODO: remove `simp`
builtin_simproc [simp, seval] isValue ((OfNat.ofNat _ : Fin _)) := fun e => do
builtin_simproc [seval] isValue ((OfNat.ofNat _ : Fin _)) := fun e => do
unless e.isAppOfArity ``OfNat.ofNat 3 do return .continue
return .done { expr := e }

View file

@ -73,8 +73,7 @@ builtin_simproc [simp, seval] reduceNeg ((- _ : Int)) := fun e => do
return .done { expr := toExpr v }
/-- Return `.done` for positive Int values. We don't want to unfold in the symbolic evaluator. -/
-- TODO: remove `simp`
builtin_simproc [simp, seval] isPosValue ((OfNat.ofNat _ : Int)) := fun e => do
builtin_simproc [seval] isPosValue ((OfNat.ofNat _ : Int)) := fun e => do
unless e.isAppOfArity ``OfNat.ofNat 3 do return .continue
return .done { expr := e }

View file

@ -55,8 +55,7 @@ builtin_simproc [simp, seval] reduceGT (( _ : Nat) > _) := reduceBinPred ``GT.
builtin_simproc [simp, seval] reduceGE (( _ : Nat) ≥ _) := reduceBinPred ``GE.ge 4 (. ≥ .)
/-- Return `.done` for Nat values. We don't want to unfold in the symbolic evaluator. -/
-- TODO: remove `simp`
builtin_simproc [simp, seval] isValue ((OfNat.ofNat _ : Nat)) := fun e => do
builtin_simproc [seval] isValue ((OfNat.ofNat _ : Nat)) := fun e => do
unless (← getContext).unfoldGround do return .continue
unless e.isAppOfArity ``OfNat.ofNat 3 do return .continue
return .done { expr := e }

View file

@ -59,8 +59,7 @@ builtin_simproc [simp, seval] $(mkIdent `reduceGT):ident (( _ : $typeName) > _)
builtin_simproc [simp, seval] $(mkIdent `reduceGE):ident (( _ : $typeName) ≥ _) := reduceBinPred ``GE.ge 4 (. ≥ .)
/-- Return `.done` for UInt values. We don't want to unfold in the symbolic evaluator. -/
-- TODO: remove `simp`
builtin_simproc [simp, seval] isValue ((OfNat.ofNat _ : $typeName)) := fun e => do
builtin_simproc [seval] isValue ((OfNat.ofNat _ : $typeName)) := fun e => do
unless (← getContext).unfoldGround do return .continue
unless (e.isAppOfArity ``OfNat.ofNat 3) do return .continue
return .done { expr := e }