fix(library/compiler/compiler): do not silently abort on user-given sorrys

src/library/compiler/compiler.cpp

@@ -93,7 +93,7 @@ environment compile(environment const & env, options const & opts, names const &
         return env;
 
     for (name const & c : cs) {
-        if (!env.get(c).is_definition() || is_builtin_constant(c) || has_sorry(env.get(c).get_value()))
+        if (!env.get(c).is_definition() || is_builtin_constant(c) || has_synthetic_sorry(env.get(c).get_value()))
             return env;
     }
     // TODO(Leo): generate boxed_version for builtin constants

tests/lean/run/array1.lean

@@ -12,10 +12,8 @@ def w : array nat :=
 def f : fin w.sz → nat :=
 array.cases_on w (λ _ f, f)
 
-constant magic {a : Prop} : a
-
-#eval f ⟨1, magic⟩
-#eval f ⟨9, magic⟩
+#eval f ⟨1, sorry⟩
+#eval f ⟨9, sorry⟩
 
 #eval (((mk_array 1 1).push 2).push 3).foldl 0 (+)
 

tests/lean/run/compiler_proj_bug.lean

@@ -4,6 +4,4 @@ structure S :=
 def f (s : S) :=
 s.b - s.a
 
-constant magic {p : Prop} : p
-
-#eval f {a := 5, b := 30, h := magic }
+#eval f {a := 5, b := 30, h := sorry }