From 8a5febf130e529734974f558f19bf0a6503db021 Mon Sep 17 00:00:00 2001
From: Sebastian Ullrich <sebasti@nullri.ch>
Date: Wed, 23 Mar 2022 19:33:25 +0100
Subject: [PATCH] chore: CI: fix release job

---
 .github/workflows/ci.yml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5f3dcc1d7d..ce47cf44ba 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -196,9 +196,13 @@ jobs:
         if: matrix.name == 'Linux'
       - name: CCache stats
         run: ccache -s
-        
+
   release:
-    if: ${{ startsWith(github.ref, 'refs/tags/v') }}
+    # When GitHub says "If a job fails, all jobs that need it are skipped unless
+    # the jobs use a conditional expression that causes the job to continue.", don't believe
+    # their lies. It's actually the entire closure (i.e. including `set-nightly`) that
+    # must succeed for subsequent to be run without `always()`.
+    if: always() && needs.build.result == 'success' && startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     needs: build
     steps: