max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: ipv4 address encoding from libuv to lean (#10854)

Browse source 
This PR fixes the IPv4 address encoding from libuv to lean
This commit is contained in:
Sofia Rodrigues 2025-10-21 11:17:22 -03:00 • committed by GitHub
parent 2f90b1dadd
commit 94cb32bc46
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 39 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/runtime/uv/dns.cpp
View file

@ -81,7 +81,19 @@ extern "C" LEAN_EXPORT lean_obj_res lean_uv_dns_get_info(b_obj_arg name, b_obj_a
for (struct addrinfo* ai = res; ai != NULL; ai = ai->ai_next) {
const struct sockaddr* sin_addr = (const struct sockaddr*)ai->ai_addr;
in_addr_storage* storage_addr = (in_addr_storage*)sin_addr->sa_data;
in_addr_storage* storage_addr;
if (sin_addr->sa_family == AF_INET) {
struct sockaddr_in* ipv4 = (struct sockaddr_in*)sin_addr;
storage_addr = (in_addr_storage*)&(ipv4->sin_addr);
} else if (sin_addr->sa_family == AF_INET6) {
struct sockaddr_in6* ipv6 = (struct sockaddr_in6*)sin_addr;
storage_addr = (in_addr_storage*)&(ipv6->sin6_addr);
} else {
continue;
}
lean_object* addr = lean_in_addr_storage_to_ip_addr((short)sin_addr->sa_family, storage_addr);
arr = lean_array_push(arr, addr);
}

26
tests/lean/run/async_dns.lean
View file

@ -31,6 +31,32 @@ def runDNSNoAscii : Async Unit := do
unless infos.size > 0 do
(throw <| IO.userError <| "No DNS results for google.com" : IO _)
let ipv4 := infos.filterMap (fun | .v4 e => some e | _ => none)
if let some head := ipv4[0]? then
let parts : Vector UInt8 4 := head.octets
let isValid :=
-- Not in 0.0.0.0/8 (current network)
parts[0] != 0 &&
-- Not in 10.0.0.0/8 (private)
parts[0] != 10 &&
-- Not in 127.0.0.0/8 (loopback)
parts[0] != 127 &&
-- Not in 169.254.0.0/16 (link-local)
!(parts[0] == 169 && parts[1] == 254) &&
-- Not in 172.16.0.0/12 (private)
!(parts[0] == 172 && parts[1] >= 16 && parts[1] <= 31) &&
-- Not in 192.168.0.0/16 (private)
!(parts[0] == 192 && parts[1] == 168) &&
-- Not in 224.0.0.0/4 (multicast)
parts[0] < 224 &&
-- Not 255.255.255.255 (broadcast)
!(parts[0] == 255 && parts[1] == 255 && parts[2] == 255 && parts[3] == 255)
unless isValid do
throw <| IO.userError <| s!"Invalid IP address for google.com: {parts[0]}.{parts[1]}.{parts[2]}.{parts[3]}"
def runReverseDNS : Async Unit := do
let result ← DNS.getNameInfo (.v4 ⟨.ofParts 8 8 8 8, 53⟩)
assertBEq result.service "domain"