max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(library/task_queue): do not keep references to cancelled task_results in the exception

Browse source 
We store this exception in the task_result itself, which creates a
reference cycle.
This commit is contained in:
Gabriel Ebner 2016-12-01 09:07:15 -05:00 • committed by Leonardo de Moura
parent d454cc8bcd
commit 9b97dc73dc
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/library/task_queue.cpp
View file

@ -72,8 +72,7 @@ task_queue & get_global_task_queue() {
return *g_tq;
}
task_cancellation_exception::task_cancellation_exception(generic_task_result const & cancelled_task) :
m_cancelled_task(cancelled_task) {
task_cancellation_exception::task_cancellation_exception(generic_task_result const & cancelled_task) {
std::ostringstream out;
if (cancelled_task) {
out << "task cancelled: " << cancelled_task.description();

3
src/library/task_queue.h
View file

@ -212,14 +212,11 @@ task_result<T> mk_pure_task_result(T const & t, std::string const & desc) {
}
class task_cancellation_exception : public std::exception {
generic_task_result m_cancelled_task;
std::string m_msg;
public:
task_cancellation_exception() : task_cancellation_exception(generic_task_result()) {}
task_cancellation_exception(generic_task_result const & cancelled_task);
char const * what() const noexcept override;
generic_task_result get_cancelled_task() const { return m_cancelled_task; }
};
class task_queue {