From bb8cc08de85f3daf67c6fb3feda245681c4b56fd Mon Sep 17 00:00:00 2001
From: Mario Carneiro <di.gama@gmail.com>
Date: Sat, 24 Jun 2023 01:25:39 -0400
Subject: [PATCH] chore: compact objects in post-order

---
 src/runtime/compact.cpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/runtime/compact.cpp b/src/runtime/compact.cpp
index 1d899fd155..b2269a4cd6 100644
--- a/src/runtime/compact.cpp
+++ b/src/runtime/compact.cpp
@@ -168,14 +168,16 @@ void object_compactor::insert_string(object * o) {
 
 bool object_compactor::insert_constructor(object * o) {
     std::vector<object_offset> & offsets = m_tmp;
-    offsets.clear();
     bool missing_children = false;
     unsigned num_objs     = lean_ctor_num_objs(o);
-    for (unsigned i = 0; i < num_objs; i++) {
+    offsets.resize(num_objs);
+    unsigned i = num_objs;
+    while (i > 0) {
+        i--;
         object_offset c = to_offset(cnstr_get(o, i));
         if (c == g_null_offset)
             missing_children = true;
-        offsets.push_back(c);
+        offsets[i] = c;
     }
     if (missing_children)
         return false;
@@ -197,15 +199,17 @@ bool object_compactor::insert_constructor(object * o) {
 
 bool object_compactor::insert_array(object * o) {
     std::vector<object_offset> & offsets = m_tmp;
-    offsets.clear();
     bool missing_children = false;
     size_t sz = array_size(o);
+    offsets.resize(sz);
     // std::cout << sz << " array\n";
-    for (size_t i = 0; i < sz; i++) {
+    size_t i = sz;
+    while (i > 0) {
+        i--;
         object_offset c = to_offset(array_get(o, i));
         if (c == g_null_offset)
             missing_children = true;
-        offsets.push_back(c);
+        offsets[i] = c;
     }
     if (missing_children)
         return false;