max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: avoid unnecessary page allocation

Browse source 
When import objects deleted by other threads, we may add elements to
`p` free list.
This commit is contained in:
Leonardo de Moura 2020-11-29 13:33:06 -08:00
parent 6dd3616298
commit dfd1f23030
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/runtime/alloc.cpp
View file

@ -370,7 +370,10 @@ extern "C" void * lean_alloc_small(unsigned sz, unsigned slot_idx) {
if (LEAN_UNLIKELY(r == nullptr)) {
if (g_heap->m_page_free_list[slot_idx] == nullptr) {
g_heap->import_objs();
p = alloc_page(g_heap, sz);
lean_assert(g_heap->m_curr_page[slot_idx] == p);
/* g_heap->import_objs() may add objects to p->m_header.m_free_list */
if (p->m_header.m_free_list == nullptr)
p = alloc_page(g_heap, sz);
} else {
p = page_list_pop(g_heap->m_page_free_list[slot_idx]);
p->m_header.m_in_page_free_list = false;