max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: checkAssignment must be at assignConst

Browse source 
Example of issue fixed by this commit: the variables `xs` may have references to `mvar`.
This commit is contained in:
Leonardo de Moura 2021-01-29 11:59:58 -08:00
parent c86803392e
commit e102cd4f42
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/Lean/Meta/ExprDefEq.lean
View file

@ -846,17 +846,18 @@ private def assignConst (mvar : Expr) (numArgs : Nat) (v : Expr) : MetaM Bool :=
pure false
else
let some v ← mkLambdaFVarsWithLetDeps xs v | pure false
trace[Meta.isDefEq.constApprox]! "{mvar} := {v}"
checkTypesAndAssign mvar v
match (← checkAssignment mvar.mvarId! #[] v) with
| none => pure false
| some v =>
trace[Meta.isDefEq.constApprox]! "{mvar} := {v}"
checkTypesAndAssign mvar v
private def processConstApprox (mvar : Expr) (numArgs : Nat) (v : Expr) : MetaM Bool := do
let cfg ← getConfig
let mvarId := mvar.mvarId!
let mvarDecl ← getMVarDecl mvarId
if mvarDecl.numScopeArgs == numArgs || cfg.constApprox then
match (← checkAssignment mvarId #[] v) with
| none => pure false
| some v => assignConst mvar numArgs v
assignConst mvar numArgs v
else
pure false