max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: actually catch the error code from MoveFileEx (#3753)

Browse source 
A user on Zulip [reported seeing an error code of "no
error"](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60lake.20update.60.20broken.20on.20Windows.20.28.3F.29/near/429134334)
here.
This commit is contained in:
Eric Wieser 2024-03-26 09:00:25 +00:00 • committed by GitHub
parent 4c0106d757
commit e8a2786d6d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/runtime/io.cpp
View file

@ -788,17 +788,21 @@ extern "C" LEAN_EXPORT obj_res lean_io_rename(b_obj_arg from, b_obj_arg to, lean
// so we have to call the underlying windows API directly to get behavior consistent
// with the unix-like OSs
bool ok = MoveFileEx(string_cstr(from), string_cstr(to), MOVEFILE_REPLACE_EXISTING) != 0;
if (!ok) {
// TODO: actually produce the right type of IO error
return io_result_mk_error((sstream()
<< "failed to rename '" << string_cstr(from) << "' to '" << string_cstr(to) << "': " << GetLastError()).str());
}
#else
bool ok = std::rename(string_cstr(from), string_cstr(to)) == 0;
#endif
if (ok) {
return io_result_mk_ok(box(0));
} else {
if (!ok) {
std::ostringstream s;
s << string_cstr(from) << " and/or " << string_cstr(to);
object_ref out{mk_string(s.str())};
return io_result_mk_error(decode_io_error(errno, out.raw()));
}
#endif
return io_result_mk_ok(box(0));
}
extern "C" LEAN_EXPORT obj_res lean_io_remove_file(b_obj_arg fname, obj_arg) {