From e99f8a9d22ee7a3c3bba59be81e8b3843601498a Mon Sep 17 00:00:00 2001
From: Leonardo de Moura <leonardo@microsoft.com>
Date: Wed, 27 Nov 2019 05:50:31 -0800
Subject: [PATCH] chore: naming convention

suffix `?` should only be used for functions/methods returning `Bool`.
---
 src/Init/Lean/Meta/Basic.lean     | 8 ++++----
 src/Init/Lean/Meta/ExprDefEq.lean | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Init/Lean/Meta/Basic.lean b/src/Init/Lean/Meta/Basic.lean
index 71b59bb4da..7dffffae44 100644
--- a/src/Init/Lean/Meta/Basic.lean
+++ b/src/Init/Lean/Meta/Basic.lean
@@ -231,10 +231,10 @@ throwEx $ Exception.bug b
 do ctx ← read;
    when ctx.config.debug (do x; pure ())
 
-@[inline] def reduceAll? : MetaM Bool :=
+@[inline] def shouldReduceAll : MetaM Bool :=
 do ctx ← read; pure $ ctx.config.transparency == TransparencyMode.all
 
-@[inline] def reduceReducibleOnly? : MetaM Bool :=
+@[inline] def shouldReduceReducibleOnly : MetaM Bool :=
 do ctx ← read; pure $ ctx.config.transparency == TransparencyMode.reducible
 
 @[inline] def getTransparency : MetaM TransparencyMode :=
@@ -312,9 +312,9 @@ def getConstAux (constName : Name) (exception? : Bool) : MetaM (Option ConstantI
 do env ← getEnv;
    match env.find constName with
    | some (info@(ConstantInfo.thmInfo _)) =>
-     condM reduceAll? (pure (some info)) (pure none)
+     condM shouldReduceAll (pure (some info)) (pure none)
    | some (info@(ConstantInfo.defnInfo _)) =>
-     condM reduceReducibleOnly?
+     condM shouldReduceReducibleOnly
        (condM (isReducible constName) (pure (some info)) (pure none))
        (pure (some info))
    | some info => pure (some info)
diff --git a/src/Init/Lean/Meta/ExprDefEq.lean b/src/Init/Lean/Meta/ExprDefEq.lean
index 306cb77bb2..3268159452 100644
--- a/src/Init/Lean/Meta/ExprDefEq.lean
+++ b/src/Init/Lean/Meta/ExprDefEq.lean
@@ -805,7 +805,7 @@ else
 
   Auxiliary method for isDefEqDelta -/
 private def unfoldReducibeDefEq (tInfo sInfo : ConstantInfo) (t s : Expr) : MetaM LBool :=
-condM reduceReducibleOnly?
+condM shouldReduceReducibleOnly
   (unfoldDefEq tInfo sInfo t s)
   (do tReducible ← isReducible tInfo.name;
       sReducible ← isReducible sInfo.name;