fix: discrepancy in the elaborators for theorem, def, and example (#4482)
When the type of a definition or example is a proposition,
we should elaborate on them as we elaborate on theorems.
This is particularly important for examples that are often
used in educational material.
Recall that when elaborating theorem headers, we convert unassigned
universe metavariables into universe parameters. The motivation is
that the proof of a theorem should not influence its statement.
However, before this commit, this was not the case for definitions and
examples when their type was a proposition. This discrepancy often
confused users.
Additionally, we considered extending the above behavior whenever
the type of a definition is provided. That is, we would keep the
current behavior only if `: <type>` was omitted in a definition.
However, this proved to be too restrictive.
For example, the following instance in `Core.lean` would fail:
```
instance {α : Sort u} [Setoid α] : HasEquiv α :=
⟨Setoid.r⟩
```
and we would have to write instead:
```
instance {α : Sort u} [Setoid α] : HasEquiv.{u, 0} α :=
⟨Setoid.r⟩
```
There are other failures like this in the core, and we assume many more
in Mathlib.
closes #4398
@semorrison @jcommelin: what do you think?
This commit is contained in:
parent
18c97926a1
commit
ee42c3ca56
2 changed files with 2 additions and 5 deletions
|
|
@ -846,10 +846,7 @@ private def levelMVarToParamHeaders (views : Array DefView) (headers : Array Def
|
|||
let rec process : StateRefT Nat TermElabM (Array DefViewElabHeader) := do
|
||||
let mut newHeaders := #[]
|
||||
for view in views, header in headers do
|
||||
-- Remark: we should consider using `pure view.kind.isTheorem <||> isProp header.type`, and
|
||||
-- also handle definitions. We used the following approach because it is less disruptive to Mathlib.
|
||||
-- Moreover, the type of most definitions are not propositions anyway.
|
||||
if ← pure view.kind.isTheorem <||> (pure view.kind.isExample <&&> isProp header.type) then
|
||||
if ← pure view.kind.isTheorem <||> isProp header.type then
|
||||
newHeaders ←
|
||||
withLevelNames header.levelNames do
|
||||
return newHeaders.push { header with type := (← levelMVarToParam header.type), levelNames := (← getLevelNames) }
|
||||
|
|
|
|||
|
|
@ -5,4 +5,4 @@ argument
|
|||
has type
|
||||
Prop : Type
|
||||
but is expected to have type
|
||||
α : Sort ?u
|
||||
α : Sort u_1
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue