From f7651de4243536f7481f1001112192f01cea32d8 Mon Sep 17 00:00:00 2001
From: Sebastian Ullrich <sebasti@nullri.ch>
Date: Fri, 14 Oct 2022 13:23:30 +0200
Subject: [PATCH] chore: CI: avoid skipped dependencies hellhole

---
 .github/workflows/ci.yml | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7dbec868e5..4decd0049e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,15 +17,16 @@ concurrency:
 
 jobs:
   set-nightly:
-    # don't schedule nightlies on forks
-    if: github.event_name == 'schedule' && github.repository == 'leanprover/lean4'
     runs-on: ubuntu-latest
     outputs:
       nightly: ${{ steps.set.outputs.nightly }}
     steps:
       - name: Checkout
         uses: actions/checkout@v2
+        # don't schedule nightlies on forks
+        if: github.event_name == 'schedule' && github.repository == 'leanprover/lean4'
       - name: Set Nightly
+        if: github.event_name == 'schedule' && github.repository == 'leanprover/lean4'
         id: set
         run: |
           if [[ -n '${{ secrets.PUSH_NIGHTLY_TOKEN }}' ]]; then
@@ -40,8 +41,7 @@ jobs:
 
   build:
     needs: set-nightly
-    # `failure` to continue even after a dependency was skipped
-    if: (success() || failure()) && (github.event_name != 'schedule' || github.repository == 'leanprover/lean4')
+    if: github.event_name != 'schedule' || github.repository == 'leanprover/lean4'
     runs-on: ${{ matrix.os }}
     defaults:
       run:
@@ -233,11 +233,7 @@ jobs:
         run: ccache -s
 
   release:
-    # When GitHub says "If a job fails, all jobs that need it are skipped unless
-    # the jobs use a conditional expression that causes the job to continue.", don't believe
-    # their lies. It's actually the entire closure (i.e. including `set-nightly`) that
-    # must succeed for subsequent to be run without the conditional.
-    if: (success() || failure()) && needs.build.result == 'success' && startsWith(github.ref, 'refs/tags/v')
+    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     needs: build
     steps: