e01cbf2b8f
This PR adds a `result? : Option TraceResult` field to `TraceData` and populates it in `withTraceNode` and `withTraceNodeBefore`, so that metaprograms walking trace trees can determine success/failure structurally instead of string-matching on emoji. `TraceResult` has three cases: `.success` (checkEmoji), `.failure` (crossEmoji), and `.error` (bombEmoji, exception thrown). An `ExceptToTraceResult` typeclass converts `Except` results to `TraceResult` directly, with instances for `Bool` and `Option`. `TraceResult.toEmoji` converts back to emoji for display. This replaces the previous `ExceptToEmoji` typeclass — `TraceResult` is now the primary representation rather than being derived from emoji strings. `withTraceNodeBefore` (used by `isDefEq`) uses `ExceptToTraceResult.toTraceResult` directly, correctly handling `Bool` (`.ok false` = failure) and `Option` (`.ok none` = failure), with `Except.error` mapping to `.error`. For `withTraceNode`, `result?` defaults to `none`. Callers can pass `mkResult?` to provide structured results; when set, the corresponding emoji is auto-prepended to the message. Motivated by mathlib's `#defeq_abuse` diagnostic tactic (https://github.com/leanprover-community/mathlib4/pull/35750) which currently string-matches on emoji to determine trace node outcomes. See https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/backward.2EisDefEq.2ErespectTransparency 🤖 Prepared with Claude Code --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
32 lines
686 B
Text
32 lines
686 B
Text
structure T : Prop
|
|
structure U : Prop
|
|
|
|
theorem foo : T → U := λ _ => {}
|
|
theorem bar : (_ : T := by trivial) → U := λ _ => {}
|
|
|
|
-- fails as expected
|
|
example : U := by
|
|
fail_if_success simp
|
|
sorry
|
|
|
|
-- works as expected, discharging `T` via `T.mk`
|
|
example : U := by
|
|
simp [foo, T.mk]
|
|
|
|
/--
|
|
trace: [Meta.Tactic.simp.discharge] ✅️ bar discharge ✅️
|
|
autoParam T bar._auto_1
|
|
[Meta.Tactic.simp.rewrite] T.mk:1000:
|
|
T
|
|
==>
|
|
True
|
|
[Meta.Tactic.simp.rewrite] bar:1000:
|
|
U
|
|
==>
|
|
True
|
|
-/
|
|
#guard_msgs in
|
|
example : U := by
|
|
set_option trace.Meta.Tactic.simp.discharge true in
|
|
set_option trace.Meta.Tactic.simp.rewrite true in
|
|
simp [bar, T.mk]
|