756396ad8f
This PR adds a `+all` option to `exact?` and `apply?` that collects all successful lemmas instead of stopping at the first complete solution. When `+all` is enabled: - `exact?` shows all lemmas that completely solve the goal (admits the goal with `sorry`) - `apply?` shows all lemmas including both complete and partial solutions 🤖 Prepared with Claude Code <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a +all flag to exact? and apply? to collect all successful lemmas, updates library search to support aggregation and proper star-lemma fallback, and extends the discriminator tree to extract/append dropped entries; includes tests. > > - **Tactics / UI**: > - Add `LibrarySearchConfig.all` and `+all` flag to `exact?`/`apply?` to collect all successful lemmas. > - `exact?` now aggregates complete solutions (via `addExactSuggestions`); `apply?` shows both complete and partial suggestions. > - Updated help texts and error/hint messages. > - **Library Search Core (`Lean.Meta.Tactic.LibrarySearch`)**: > - Thread new `collectAll` option through `tryOnEach`, `librarySearch'`, and `librarySearch`. > - `tryOnEach` continues collecting complete solutions when `collectAll = true`. > - Star-lemma fallback now runs even when primary search yields only partial results; include complete solutions when aggregating. > - Cache and retrieve star-indexed lemmas via `droppedEntriesRef`/`getStarLemmas`. > - **Lazy Discriminator Tree (`Lean.Meta.LazyDiscrTree`)**: > - Add `extractKey(s)`/`collectSubtreeAux` to extract and drop entries, returning them. > - Modify import/module tree building to optionally append dropped entries to a shared ref (for star-lemmas), and pass this through `findMatches`/`createModuleTreeRef`. > - Minor comment/logic tweaks (append vs set) when handling dropped entries. > - **Elaboration (`Lean.Elab.Tactic.LibrarySearch`)**: > - Integrate `collectAll` into `exact?`/`apply?`; partition and present complete vs incomplete suggestions; admit goals appropriately when aggregating. > - **Tests**: > - Update existing expectations and add `tests/lean/run/library_search_all.lean` to verify `+all`, aggregation, and star-lemma behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit cbfc9313affad45012ebd5ac40b338ee829009b1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude <noreply@anthropic.com>
3 lines
198 B
Text
3 lines
198 B
Text
librarySearch.lean:395:0-395:7: warning: declaration uses 'sorry'
|
|
librarySearch.lean:405:0-405:7: warning: declaration uses 'sorry'
|
|
librarySearch.lean:493:0-493:7: warning: declaration uses 'sorry'
|