f180eee7bf
This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
50 lines
943 B
Text
50 lines
943 B
Text
module
|
|
public section -- TODO: `try?` fails if theorems are private
|
|
opaque P : Nat → Prop
|
|
opaque Q : Nat → Prop
|
|
|
|
theorem Pall : Q x → P x := sorry
|
|
|
|
/--
|
|
info: Try this:
|
|
exact Pall h
|
|
-/
|
|
#guard_msgs (info) in
|
|
example (h : Q x) (_ : x > 0) : P x := by
|
|
try?
|
|
|
|
/--
|
|
info: Try this:
|
|
· intros; expose_names; exact Pall h
|
|
-/
|
|
#guard_msgs (info) in
|
|
example: Q x → True → P x := by
|
|
try?
|
|
|
|
/--
|
|
info: Try this:
|
|
· intros; expose_names; exact Pall h_1
|
|
-/
|
|
#guard_msgs (info) in
|
|
example: True → Q x → True → P x := by
|
|
try?
|
|
|
|
theorem Qall {x y : Nat} : Q x := sorry
|
|
|
|
/--
|
|
error: Tactic `try?` failed: consider using `grind` manually, or `try? +missing` for partial proofs containing `sorry`
|
|
|
|
x : Nat
|
|
⊢ Q x
|
|
-/
|
|
#guard_msgs (error) in
|
|
example : Q x := by
|
|
try? -- should fail, we cannot elaborate `exact Qall`
|
|
|
|
/--
|
|
info: Try this:
|
|
· expose_names; exact Pall h
|
|
-/
|
|
#guard_msgs (info) in
|
|
example (_ : Q x) (_ : x > 0) : P x := by
|
|
try?
|