This PR speeds up auto-completion by a factor of ~3.5x through various performance improvements in the language server. On one machine, with `import Mathlib`, completing `i` used to take 3200ms and now instead yields a result in 920ms. Specifically, the following improvements are made: - The watchdog process no longer de-serializes and re-serializes most messages from the file worker before passing them on to the user - a fast partial de-serialization procedure is now used to determine whether the message needs to be de-serialized in full or not. - `escapePart` is optimized to perform better on ASCII strings that do not need escaping. - `Json.compress` is optimized to allocate fewer objects. - A faster JSON compression specifically for completion responses is implemented that skips allocating `Json` altogether. - The JSON compression has been moved to the task where we convert a request response to `Json` so that converting to a string won't block the output task of the FileWorker and so the `Json` value is not marked as multi-threaded when we compress is, which drastically increases the cost of reference-counting. - The JSON representation of the `data?` field of each completion item is optimized. - Both the completion kind and the set of completion tags for each imported completion item is now cached. - The filtering of duplicate completion items is optimized. Other adjustments: - `LT UInt8` and `LE UInt8` are moved to Prelude so that they can be used in `Init.Meta` for the name part escaping fast path. - `Array.usize` is exposed since it was marked as `@[simp]`.
61 lines
2.2 KiB
Text
61 lines
2.2 KiB
Text
{"textDocument": {"uri": "file:///completion2.lean"},
|
|
"position": {"line": 19, "character": 10}}
|
|
{"items":
|
|
[{"label": "ex2",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 19, 10, 0, "cFoo.Bla.ex2"]},
|
|
{"label": "ex3",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 19, 10, 0, "cFoo.Bla.ex3"]},
|
|
{"label": "ex1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 19, 10, 0, "cFoo.Bla.ex1"]},
|
|
{"label": "ax1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 19, 10, 0, "cFoo.Bla.ax1"]}],
|
|
"isIncomplete": false}
|
|
{"textDocument": {"uri": "file:///completion2.lean"},
|
|
"position": {"line": 25, "character": 6}}
|
|
{"items":
|
|
[{"label": "ex2",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 25, 6, 0, "cFoo.Bla.ex2"]},
|
|
{"label": "ex3",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 25, 6, 0, "cFoo.Bla.ex3"]},
|
|
{"label": "ex1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 25, 6, 0, "cFoo.Bla.ex1"]},
|
|
{"label": "ax1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 25, 6, 0, "cFoo.Bla.ax1"]}],
|
|
"isIncomplete": false}
|
|
{"textDocument": {"uri": "file:///completion2.lean"},
|
|
"position": {"line": 30, "character": 21}}
|
|
{"items":
|
|
[{"label": "ex2",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 30, 21, 0, "cFoo.Bla.ex2"]},
|
|
{"label": "ex3",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 30, 21, 0, "cFoo.Bla.ex3"]},
|
|
{"label": "ex1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 30, 21, 0, "cFoo.Bla.ex1"]},
|
|
{"label": "ax1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 30, 21, 0, "cFoo.Bla.ax1"]}],
|
|
"isIncomplete": false}
|
|
{"textDocument": {"uri": "file:///completion2.lean"},
|
|
"position": {"line": 37, "character": 22}}
|
|
{"items":
|
|
[{"label": "ex2",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 37, 22, 0, "cFoo.Bla.ex2"]},
|
|
{"label": "ex3",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 37, 22, 0, "cFoo.Bla.ex3"]},
|
|
{"label": "ex1",
|
|
"kind": 23,
|
|
"data": ["«external:file:///completion2.lean»", 37, 22, 0, "cFoo.Bla.ex1"]}],
|
|
"isIncomplete": false}
|