f180eee7bf
This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
20 lines
515 B
Text
20 lines
515 B
Text
universe u
|
||
|
||
class MyClass (α : Type u) extends LE α where
|
||
sup : α → α → α
|
||
le_refl : ∀ a : α, a ≤ a
|
||
sup_of_le_left : ∀ a b : α, b ≤ a → sup a b = a
|
||
|
||
instance : MyClass Prop where
|
||
le p q := p → q
|
||
sup p q := p ∨ q
|
||
le_refl _ := id
|
||
sup_of_le_left _ _ h := propext ⟨Or.rec id h, Or.inl⟩
|
||
|
||
/--
|
||
info: Try this:
|
||
simp only [MyClass.le_refl, MyClass.sup_of_le_left]
|
||
-/
|
||
#guard_msgs in
|
||
example : MyClass.sup False False = False := by
|
||
simp? [MyClass.sup_of_le_left, MyClass.le_refl]
|