f180eee7bf
This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
44 lines
855 B
Text
44 lines
855 B
Text
/--
|
|
info: Try this:
|
|
termination_by xs.length / 2 - i
|
|
-/
|
|
#guard_msgs in
|
|
def foo (xs : String) (i : Nat) (a b : String.Iterator) : Bool :=
|
|
if xs.length / 2 ≤ i then
|
|
true
|
|
else if a.curr ≠ b.curr then
|
|
false
|
|
else
|
|
foo xs (i + 1) a.next b.prev
|
|
termination_by?
|
|
|
|
/--
|
|
info: Try this:
|
|
termination_by xs.length / 2 - i
|
|
-/
|
|
#guard_msgs in
|
|
def bar (xs : String) (i : Nat) (a b : String.Iterator) : Bool :=
|
|
if i < xs.length / 2 then
|
|
if a.curr ≠ b.curr then
|
|
false
|
|
else
|
|
bar xs (i + 1) a.next b.prev
|
|
else
|
|
true
|
|
termination_by?
|
|
|
|
|
|
/--
|
|
info: Try this:
|
|
termination_by xs.length / 2 - i
|
|
-/
|
|
#guard_msgs in
|
|
def baz (xs : String) (i : Nat) (a b : String.Iterator) : Bool :=
|
|
if ¬ (i < xs.length / 2) then
|
|
true
|
|
else
|
|
if a.curr ≠ b.curr then
|
|
false
|
|
else
|
|
baz xs (i + 1) a.next b.prev
|
|
termination_by?
|