max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
lean4-htt/src/Lean/Data
History
Henrik Böving 723c340a8b
perf: fix linearity in (HashSet|HashMap).erase (#3887) 
Fixes linearity issues in HashSet/HashMap erase functions.

IR before patch:
```
def Lean.HashMapImp.erase._rarg (x_1 : obj) (x_2 : obj) (x_3 : obj) (x_4 : obj) : obj :=
  let x_5 : obj := proj[0] x_3;
  inc x_5;
  let x_6 : obj := proj[1] x_3;
  inc x_6;
  let x_7 : obj := Array.size ◾ x_6;
  inc x_4;
  let x_8 : obj := app x_2 x_4;
  let x_9 : u64 := unbox x_8;
  dec x_8;
  let x_10 : usize := _private.Lean.Data.HashMap.0.Lean.HashMapImp.mkIdx x_7 x_9 ◾;
  let x_11 : obj := Array.uget ◾ x_6 x_10 ◾;
  inc x_11;
  inc x_4;
  inc x_1;
  let x_12 : u8 := Lean.AssocList.contains._rarg x_1 x_4 x_11;
  case x_12 : u8 of
  Bool.false →
    dec x_11;
    dec x_6;
    dec x_5;
    dec x_4;
    dec x_1;
    ret x_3
  Bool.true →
    let x_13 : u8 := isShared x_3;
    case x_13 : u8 of
    Bool.false →
      let x_14 : obj := proj[1] x_3;
      dec x_14;
      let x_15 : obj := proj[0] x_3;
      dec x_15;
      let x_16 : obj := 1;
      let x_17 : obj := Nat.sub x_5 x_16;
      dec x_5;
      let x_18 : obj := Lean.AssocList.erase._rarg x_1 x_4 x_11;
      let x_19 : obj := Array.uset ◾ x_6 x_10 x_18 ◾;
      set x_3[1] := x_19;
      set x_3[0] := x_17;
      ret x_3
    Bool.true →
      dec x_3;
      let x_20 : obj := 1;
      let x_21 : obj := Nat.sub x_5 x_20;
      dec x_5;
      let x_22 : obj := Lean.AssocList.erase._rarg x_1 x_4 x_11;
      let x_23 : obj := Array.uset ◾ x_6 x_10 x_22 ◾;
      let x_24 : obj := ctor_0[Lean.HashMapImp.mk] x_21 x_23;
      ret x_24
```

IR after the patch:
```
def Lean.HashMapImp.erase._rarg (x_1 : obj) (x_2 : obj) (x_3 : obj) (x_4 : obj) : obj :=
  let x_5 : u8 := isShared x_3;
  case x_5 : u8 of
  Bool.false →
    let x_6 : obj := proj[0] x_3;
    let x_7 : obj := proj[1] x_3;
    let x_8 : obj := Array.size ◾ x_7;
    inc x_4;
    let x_9 : obj := app x_2 x_4;
    let x_10 : u64 := unbox x_9;
    dec x_9;
    let x_11 : usize := _private.Lean.Data.HashMap.0.Lean.HashMapImp.mkIdx x_8 x_10 ◾;
    let x_12 : obj := Array.uget ◾ x_7 x_11 ◾;
    inc x_12;
    inc x_4;
    inc x_1;
    let x_13 : u8 := Lean.AssocList.contains._rarg x_1 x_4 x_12;
    case x_13 : u8 of
    Bool.false →
      dec x_12;
      dec x_4;
      dec x_1;
      ret x_3
    Bool.true →
      let x_14 : obj := 1;
      let x_15 : obj := Nat.sub x_6 x_14;
      dec x_6;
      let x_16 : obj := Lean.AssocList.erase._rarg x_1 x_4 x_12;
      let x_17 : obj := Array.uset ◾ x_7 x_11 x_16 ◾;
      set x_3[1] := x_17;
      set x_3[0] := x_15;
      ret x_3
  Bool.true →
    let x_18 : obj := proj[0] x_3;
    let x_19 : obj := proj[1] x_3;
    inc x_19;
    inc x_18;
    dec x_3;
    let x_20 : obj := Array.size ◾ x_19;
    inc x_4;
    let x_21 : obj := app x_2 x_4;
    let x_22 : u64 := unbox x_21;
    dec x_21;
    let x_23 : usize := _private.Lean.Data.HashMap.0.Lean.HashMapImp.mkIdx x_20 x_22 ◾;
    let x_24 : obj := Array.uget ◾ x_19 x_23 ◾;
    inc x_24;
    inc x_4;
    inc x_1;
    let x_25 : u8 := Lean.AssocList.contains._rarg x_1 x_4 x_24;
    case x_25 : u8 of
    Bool.false →
      dec x_24;
      dec x_4;
      dec x_1;
      let x_26 : obj := ctor_0[Lean.HashMapImp.mk] x_18 x_19;
      ret x_26
    Bool.true →
      let x_27 : obj := 1;
      let x_28 : obj := Nat.sub x_18 x_27;
      dec x_18;
      let x_29 : obj := Lean.AssocList.erase._rarg x_1 x_4 x_24;
      let x_30 : obj := Array.uset ◾ x_19 x_23 x_29 ◾;
      let x_31 : obj := ctor_0[Lean.HashMapImp.mk] x_28 x_30;
      ret x_31
```

Previously `x_6` (the buckets array) always gets `inc`remented, now only
if the HashMap itself is shared.
2024-04-12 08:54:21 +00:00
..
Json chore: reorganising to reduce imports (#3790) 2024-03-27 11:15:01 +00:00
Lsp feat: diagnostics for stale dependencies (#3247) 2024-03-18 10:38:38 +00:00
Xml chore: reorganising to reduce imports (#3790) 2024-03-27 11:15:01 +00:00
Array.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
AssocList.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Format.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
FuzzyMatching.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
HashMap.lean perf: fix linearity in (HashSet|HashMap).erase (#3887) 2024-04-12 08:54:21 +00:00
HashSet.lean perf: fix linearity in (HashSet|HashMap).erase (#3887) 2024-04-12 08:54:21 +00:00
Json.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
JsonRpc.lean feat: snapshot trees and language processors (#3014) 2024-03-14 13:40:08 +00:00
KVMap.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
LBool.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
LOption.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Lsp.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Name.lean chore: remove the coercion from String to Name (#3589) 2024-03-21 23:46:03 +00:00
NameMap.lean chore: remove the coercion from String to Name (#3589) 2024-03-21 23:46:03 +00:00
NameTrie.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
OpenDecl.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Options.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Parsec.lean chore: reorganising to reduce imports (#3790) 2024-03-27 11:15:01 +00:00
PersistentArray.lean chore: extend GetElem with getElem! and getElem? (#3694) 2024-03-28 01:42:00 +00:00
PersistentHashMap.lean fix: simp usedSimps (#3821) 2024-04-02 00:50:06 +00:00
PersistentHashSet.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Position.lean chore: remove FileMap.lines and add FileMap.getLine (#3237) 2024-03-25 10:33:04 +00:00
PrefixTree.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Rat.lean chore: reorganising to reduce imports (#3790) 2024-03-27 11:15:01 +00:00
RBMap.lean chore: upstream solve_by_elim (#3408) 2024-02-21 01:16:04 +00:00
RBTree.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
SMap.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
SSet.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Trie.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Xml.lean chore: add missing copyright headers (#3411) 2024-02-20 01:49:55 +00:00