lean4-htt/src/frontends/lean/local_context_adapter.cpp
Leonardo de Moura 85092412c7 refactor: remove Expr.FVar hack
@Kha @dselsam:
This hack was preventing us from making `Expr` a "real" Lean type.
This was bad for a few reasons:
- It was hard to extend/modify `Expr` in Lean since we would also have
to modify the C++ code that creates the `Expr` objects with the hidden
fields.
- `Expr.lam` and `Expr.forallE` were not following the Lean layout
standard where we sort fields by size. @Kha: recall we used that to
avoid a UB. The issue with `Expr.lam` and `Expr.forallE` is that they
have a "visible" field (`BinderInfo`), which is smaller than
hidden fields such as hash code.
- `Expr.fvar` had only one field at `Expr.lean,` but four behind the
scenes.

I added a new constructor `Local` that is only accessible from C++.
It is only used in legacy code we inherited from Lean2.
We will eventually delete it.

This refactoring was quite painful since many parts of the codebase
were mixing the new `Expr.fvar` with the old `Expr.local`.
I doubt I would be able to do it without the new staging framework
@Kha built.

BTW, some of the patches are horrible. I didn't care much since we
are going to deleted the super ugly files. That being said,
you should expect new weird bevaior due to `Expr.fvar` vs `Expr.local`.

Next step: use the new `ExprCachedData` to make all `Expr` hidden visibles
accessible from Lean.

checkpoint
2019-11-15 14:04:26 -08:00

72 lines
2.3 KiB
C++

/*
Copyright (c) 2016 Microsoft Corporation. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Author: Leonardo de Moura
*/
#include "kernel/instantiate.h"
#include "kernel/abstract.h"
#include "kernel/find_fn.h"
#include "library/locals.h"
#include "library/pos_info_provider.h"
#include "frontends/lean/local_context_adapter.h"
namespace lean {
bool local_context_adapter::has_local_ref(expr const & e) {
return static_cast<bool>(find(e, [](expr const & e, unsigned) { return is_fvar(e); }));
}
bool local_context_adapter::has_regular_local(expr const & e) {
return static_cast<bool>(find(e, [](expr const & e, unsigned) { return is_local(e); }));
}
void local_context_adapter::add_local(expr const & local) {
lean_assert(is_local(local));
expr const & _local_type = local_type(local);
expr new_local_type = translate_to(_local_type);
expr new_local_ref = m_lctx.mk_local_decl(local_pp_name(local), new_local_type, local_info(local));
lean_assert(is_fvar(new_local_ref));
m_locals.push_back(local);
m_local_refs.push_back(new_local_ref);
}
local_context_adapter::local_context_adapter(local_expr_decls const & ldecls) {
lean_assert(m_lctx.empty() && m_locals.empty());
buffer<pair<name, expr>> entries;
to_buffer(ldecls.get_entries(), entries);
unsigned i = entries.size();
while (i > 0) {
--i;
pair<name, expr> const & entry = entries[i];
expr const & local = unwrap_pos(entry.second);
if (!is_local(local)) continue;
add_local(local);
}
}
local_context_adapter::local_context_adapter(list<expr> const & lctx) {
lean_assert(std::all_of(lctx.begin(), lctx.end(), is_local_p));
lean_assert(m_lctx.empty() && m_locals.empty());
buffer<expr> entries;
to_buffer(lctx, entries);
unsigned i = entries.size();
while (i > 0) {
--i;
add_local(unwrap_pos(entries[i]));
}
}
expr local_context_adapter::translate_to(expr const & e) const {
lean_assert(!has_local_ref(e));
expr r = replace_locals(e, m_locals, m_local_refs);
lean_assert(!has_regular_local(r));
return r;
}
expr local_context_adapter::translate_from(expr const & e) const {
lean_assert(!has_regular_local(e));
expr r = replace_locals(e, m_local_refs, m_locals);
lean_assert(!has_local_ref(r));
return r;
}
}