This PR is part 2 of the `implicit_reducible` refactoring (part 1: #12567). **Background.** When Lean checks definitional equality of function applications `f a₁ ... aₙ =?= f b₁ ... bₙ`, it compares arguments `aᵢ =?= bᵢ` at a transparency level determined by the binder type. Previously, only instance-implicit (`[C]`) arguments received a transparency bump to `.instances`. With `backward.isDefEq.implicitBump` enabled, ALL implicit arguments (`{x}`, `⦃x⦄`, and `[x]`) are bumped to `.instances`, so that definitions marked `[implicit_reducible]` unfold when comparing implicit arguments. This is important because implicit arguments often carry type information (e.g., `P (i + 0)` vs `P i`) where the mismatch is in non-proof positions (Sort arguments to `cast`) — proof irrelevance does not help here, so the relevant definitions must actually unfold. **`[implicit_reducible]`** (renamed from `[instance_reducible]` in part 1) marks definitions that should unfold at `TransparencyMode.instances` — between `[reducible]` (unfolds at `.reducible` and above) and the default `[semireducible]` (unfolds only at `.default` and above). This is the right level for core arithmetic operations that appear in type indices. ## Changes - **Enable `backward.isDefEq.implicitBump` by default** and set it in `stage0/src/stdlib_flags.h` so stage0 also compiles with it - **Mark `Nat.add`, `Nat.mul`, `Nat.sub`, `Array.size` as `[implicit_reducible]`** so they unfold when comparing implicit arguments at `.instances` transparency - **Remove redundant unification hints** (`n + 0 =?= n`, `n - 0 =?= n`, `n * 0 =?= 0`) that are now handled by `[implicit_reducible]` - **Rename all remaining `[instance_reducible]` attribute usages** to `[implicit_reducible]` across the codebase (the old name remains as an alias) - **Remove 28 `set_option backward.isDefEq.respectTransparency false in`** workarounds that are no longer needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
32 lines
985 B
Text
32 lines
985 B
Text
@[implicit_reducible]
|
||
def myCast : NatCast UInt8 where
|
||
natCast := UInt8.ofNat
|
||
|
||
class Semiring (α : Type u) where
|
||
[nsmul : SMul Nat α]
|
||
|
||
/--
|
||
trace: [Compiler.IR] [result]
|
||
def instSemiringUInt8._lam_0 (x_1 : @& tobj) (x_2 : u8) : u8 :=
|
||
let x_3 : u8 := UInt8.ofNat x_1;
|
||
let x_4 : u8 := UInt8.mul x_3 x_2;
|
||
ret x_4
|
||
def instSemiringUInt8._lam_0._boxed (x_1 : tobj) (x_2 : tagged) : tagged :=
|
||
let x_3 : u8 := unbox x_2;
|
||
let x_4 : u8 := instSemiringUInt8._lam_0 x_1 x_3;
|
||
dec x_1;
|
||
let x_5 : tagged := box x_4;
|
||
ret x_5
|
||
[Compiler.IR] [result]
|
||
def instSemiringUInt8._closed_0 : obj :=
|
||
let x_1 : obj := pap instSemiringUInt8._lam_0._boxed;
|
||
ret x_1
|
||
def instSemiringUInt8 : obj :=
|
||
let x_1 : obj := instSemiringUInt8._closed_0;
|
||
ret x_1
|
||
-/
|
||
#guard_msgs in
|
||
set_option trace.compiler.ir.result true in
|
||
attribute [local instance] myCast UInt8.intCast in
|
||
instance : Semiring UInt8 where
|
||
nsmul := ⟨(· * ·)⟩
|