max/lean4-htt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
lean4-htt/src/Lean
History
Sebastian Ullrich 8d3be96024
fix: tactics in terms in tactics may break incremental reporting (#4436) 
A pending tactic mvar managed to escape into an unexpected context in
specific circumstances.

```lean
example : True := by
  · rw [show 0 = 0 by rfl]
```
* Term elaboration of the `show` creates a pending mvar for the `by rfl`
proof
* `rw` fails with an exception because the pattern does not occur in the
target
* `cdot` catches the exception and admits the goal
* `Term.runTactic` [synthesizes all pending mvars from the tactic's
execution](5f9dedfe5e/src/Lean/Elab/SyntheticMVars.lean (L350)),
including the `by rfl` proof. But this would not have happened without
`cdot` as the exception would have skipped that invocation!
* Now incrementality is confused because the nested `by rfl` proof is
unexpectedly run in the same context as the top-level proof, writing to
the wrong promise, and the error message is lost

Solution: disable incrementality for these pending mvars
2024-06-12 14:59:24 +00:00
..
Compiler fix: accidental ownership with specialization 2024-06-07 13:59:22 +02:00
Data perf: linearity in HashMap.(insert|erase) (#4372) 2024-06-07 22:41:39 +00:00
Elab fix: tactics in terms in tactics may break incremental reporting (#4436) 2024-06-12 14:59:24 +00:00
Language chore: slightly more informative trace.Elab.snapshotTree 2024-06-11 10:44:04 +02:00
Linter feat: improve @[deprecated] attr (#3968) 2024-04-23 17:00:32 +00:00
Meta feat: dsimprocs for ite and dite (#4430) 2024-06-11 23:36:18 +00:00
Parser feat: quotations for parser aliases (#4307) 2024-05-30 09:22:22 +00:00
ParserCompiler feat: reserved names (#3675) 2024-03-15 00:33:22 +00:00
PrettyPrinter chore: missing registerTraceClass (#4369) 2024-06-06 00:53:16 +00:00
Server feat: incremental elaboration of definition headers, bodies, and tactics (#3940) 2024-05-22 13:23:30 +00:00
Util feat: apply’s error message should show implicit arguments as needed (#3929) 2024-05-18 06:25:43 +00:00
Widget feat: widget messages (#4254) 2024-05-29 06:37:42 +00:00
AddDecl.lean feat: propagate maxHeartbeats to kernel (#4113) 2024-05-09 17:44:19 +00:00
Attributes.lean fix: docstring in Attributes.lean (#4238) 2024-05-23 10:13:43 +00:00
AuxRecursor.lean chore: remove the coercion from String to Name (#3589) 2024-03-21 23:46:03 +00:00
BuiltinDocAttr.lean feat: @[builtin_doc] attribute (part 1) (#3953) 2024-04-19 12:21:10 +00:00
Class.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Compiler.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
CoreM.lean fix: incorrect info tree reuse (#4340) 2024-06-04 09:28:40 +00:00
Data.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Declaration.lean fix: mismatch between TheoremVal in Lean and C++ (#4035) 2024-04-30 18:10:20 +00:00
DeclarationRange.lean feat: snapshot trees and language processors (#3014) 2024-03-14 13:40:08 +00:00
DocString.lean fix: missing test at addDocString (#3823) 2024-04-02 02:29:14 +00:00
Elab.lean feat: macro expander for match_expr terms 2024-03-01 22:33:14 -08:00
Environment.lean feat: propagate maxHeartbeats to kernel (#4113) 2024-05-09 17:44:19 +00:00
Eval.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Exception.lean feat: apply’s error message should show implicit arguments as needed (#3929) 2024-05-18 06:25:43 +00:00
Expr.lean feat: shorten auto-generated instance names (#3089) 2024-04-13 18:08:50 +00:00
HeadIndex.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Hygiene.lean chore: remove the coercion from String to Name (#3589) 2024-03-21 23:46:03 +00:00
ImportingFlag.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
InternalExceptionId.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
KeyedDeclsAttribute.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
LabelAttribute.lean chore: reorganising to reduce imports (#3790) 2024-03-27 11:15:01 +00:00
LazyInitExtension.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Level.lean chore: remove partial TODO (#4380) 2024-06-06 18:04:55 +00:00
Linter.lean chore: add missing copyright headers (#3411) 2024-02-20 01:49:55 +00:00
LoadDynlib.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
LocalContext.lean chore: upstream omega (#3367) 2024-02-19 00:19:55 +00:00
Log.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Message.lean feat: widget messages (#4254) 2024-05-29 06:37:42 +00:00
Meta.lean feat: improve set_option diagnostics true (#4031) 2024-04-30 05:07:03 +00:00
MetavarContext.lean fix: occurs check at metavariable types (#4420) 2024-06-11 00:16:19 +00:00
Modifiers.lean fix: auto-completion bugs and performance (#3460) 2024-02-26 09:43:19 +00:00
MonadEnv.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Parser.lean chore: remove the coercion from String to Name (#3589) 2024-03-21 23:46:03 +00:00
ParserCompiler.lean refactor: Offset.lean and related files (#3614) 2024-03-05 19:40:15 -08:00
PrettyPrinter.lean feat: apply’s error message should show implicit arguments as needed (#3929) 2024-05-18 06:25:43 +00:00
ProjFns.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
ReducibilityAttrs.lean feat: well-founded definitions irreducible by default (#4061) 2024-05-10 06:45:21 +00:00
Replay.lean feat: propagate maxHeartbeats to kernel (#4113) 2024-05-09 17:44:19 +00:00
ReservedNameAction.lean fix: FunInd: support structural recursion on reflexive types (#4327) 2024-06-05 07:54:48 +00:00
ResolveName.lean chore: tidying up Lean.unresolveNameGlobal (#4091) 2024-05-10 22:37:34 +00:00
Runtime.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
ScopedEnvExtension.lean feat: flexible reducibility attributes 2024-04-29 05:46:11 +02:00
Server.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
Structure.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00
SubExpr.lean fix: use correct expr positions when delaborating match patterns (#4034) 2024-05-01 12:02:10 +00:00
Syntax.lean fix: incremental reuse leading to goals in front of the text cursor being shown (#4395) 2024-06-08 15:08:14 +00:00
ToExpr.lean feat: support idents in auto tactics (#3328) 2024-05-03 04:37:07 +00:00
Util.lean chore: upstream exact? and apply? from Std (#3447) 2024-02-23 21:55:24 +00:00
Widget.lean perf: add prelude to all Lean modules 2024-02-18 14:55:17 -08:00