This PR adds further automation to the release process, taking care of tagging, and creating new `bump/v4.X.0` branches automatically, and fixing some bugs. --------- Co-authored-by: Johan Commelin <johan@commelin.net>
420 lines
19 KiB
Python
Executable file
420 lines
19 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
|
|
import argparse
|
|
import yaml
|
|
import requests
|
|
import base64
|
|
import subprocess
|
|
import sys
|
|
import os
|
|
# Import run_command from merge_remote.py
|
|
from merge_remote import run_command
|
|
|
|
def debug(verbose, message):
|
|
"""Print debug message if verbose mode is enabled."""
|
|
if verbose:
|
|
print(f" [DEBUG] {message}")
|
|
|
|
def parse_repos_config(file_path):
|
|
with open(file_path, "r") as f:
|
|
return yaml.safe_load(f)["repositories"]
|
|
|
|
def get_github_token():
|
|
try:
|
|
import subprocess
|
|
result = subprocess.run(['gh', 'auth', 'token'], capture_output=True, text=True)
|
|
if result.returncode == 0:
|
|
return result.stdout.strip()
|
|
except FileNotFoundError:
|
|
print("Warning: 'gh' CLI not found. Some API calls may be rate-limited.")
|
|
return None
|
|
|
|
def strip_rc_suffix(toolchain):
|
|
"""Remove -rcX suffix from the toolchain."""
|
|
return toolchain.split("-")[0]
|
|
|
|
def branch_exists(repo_url, branch, github_token):
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + f"/branches/{branch}"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
response = requests.get(api_url, headers=headers)
|
|
return response.status_code == 200
|
|
|
|
def tag_exists(repo_url, tag_name, github_token):
|
|
# Use /git/matching-refs/tags/ to get all matching tags
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + f"/git/matching-refs/tags/{tag_name}"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
response = requests.get(api_url, headers=headers)
|
|
|
|
if response.status_code != 200:
|
|
return False
|
|
|
|
# Check if any of the returned refs exactly match our tag
|
|
matching_tags = response.json()
|
|
return any(tag["ref"] == f"refs/tags/{tag_name}" for tag in matching_tags)
|
|
|
|
def release_page_exists(repo_url, tag_name, github_token):
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + f"/releases/tags/{tag_name}"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
response = requests.get(api_url, headers=headers)
|
|
return response.status_code == 200
|
|
|
|
def get_release_notes(repo_url, tag_name, github_token):
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + f"/releases/tags/{tag_name}"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
response = requests.get(api_url, headers=headers)
|
|
if response.status_code == 200:
|
|
return response.json().get("body", "").strip()
|
|
return None
|
|
|
|
def get_branch_content(repo_url, branch, file_path, github_token):
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + f"/contents/{file_path}?ref={branch}"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
response = requests.get(api_url, headers=headers)
|
|
if response.status_code == 200:
|
|
content = response.json().get("content", "")
|
|
content = content.replace("\n", "")
|
|
try:
|
|
return base64.b64decode(content).decode('utf-8').strip()
|
|
except Exception:
|
|
return None
|
|
return None
|
|
|
|
def parse_version(version_str):
|
|
# Remove 'v' prefix and extract version and release candidate suffix
|
|
if ':' in version_str:
|
|
version_str = version_str.split(':')[1]
|
|
version = version_str.lstrip('v')
|
|
parts = version.split('-')
|
|
base_version = tuple(map(int, parts[0].split('.')))
|
|
rc_part = parts[1] if len(parts) > 1 and parts[1].startswith('rc') else None
|
|
rc_number = int(rc_part[2:]) if rc_part else float('inf') # Treat non-rc as higher than rc
|
|
return base_version + (rc_number,)
|
|
|
|
def is_version_gte(version1, version2):
|
|
"""Check if version1 >= version2, including proper handling of release candidates."""
|
|
# Check if version1 is a nightly toolchain
|
|
if version1.startswith("leanprover/lean4:nightly-"):
|
|
return False
|
|
return parse_version(version1) >= parse_version(version2)
|
|
|
|
def is_merged_into_stable(repo_url, tag_name, stable_branch, github_token, verbose=False):
|
|
# First get the commit SHA for the tag
|
|
api_base = repo_url.replace("https://github.com/", "https://api.github.com/repos/")
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
|
|
# Get tag's commit SHA
|
|
tag_response = requests.get(f"{api_base}/git/refs/tags/{tag_name}", headers=headers)
|
|
if tag_response.status_code != 200:
|
|
debug(verbose, f"Could not fetch tag {tag_name}, status code: {tag_response.status_code}")
|
|
return False
|
|
|
|
# Handle both single object and array responses
|
|
tag_data = tag_response.json()
|
|
if isinstance(tag_data, list):
|
|
# Find the exact matching tag in the list
|
|
matching_tags = [tag for tag in tag_data if tag['ref'] == f'refs/tags/{tag_name}']
|
|
if not matching_tags:
|
|
debug(verbose, f"No matching tag found for {tag_name} in response list")
|
|
return False
|
|
tag_sha = matching_tags[0]['object']['sha']
|
|
else:
|
|
tag_sha = tag_data['object']['sha']
|
|
|
|
# Check if the tag is an annotated tag and get the actual commit SHA
|
|
if tag_data.get('object', {}).get('type') == 'tag' or (
|
|
isinstance(tag_data, list) and
|
|
matching_tags and
|
|
matching_tags[0].get('object', {}).get('type') == 'tag'):
|
|
|
|
# Get the commit that this tag points to
|
|
tag_obj_response = requests.get(f"{api_base}/git/tags/{tag_sha}", headers=headers)
|
|
if tag_obj_response.status_code == 200:
|
|
tag_obj = tag_obj_response.json()
|
|
if 'object' in tag_obj and tag_obj['object']['type'] == 'commit':
|
|
commit_sha = tag_obj['object']['sha']
|
|
debug(verbose, f"Tag is annotated. Resolved commit SHA: {commit_sha}")
|
|
tag_sha = commit_sha # Use the actual commit SHA
|
|
|
|
# Get commits on stable branch containing this SHA
|
|
commits_response = requests.get(
|
|
f"{api_base}/commits?sha={stable_branch}&per_page=100",
|
|
headers=headers
|
|
)
|
|
if commits_response.status_code != 200:
|
|
debug(verbose, f"Could not fetch commits for branch {stable_branch}, status code: {commits_response.status_code}")
|
|
return False
|
|
|
|
# Check if any commit in stable's history matches our tag's SHA
|
|
stable_commits = [commit['sha'] for commit in commits_response.json()]
|
|
|
|
is_merged = tag_sha in stable_commits
|
|
|
|
debug(verbose, f"Tag SHA: {tag_sha}")
|
|
debug(verbose, f"First 5 stable commits: {stable_commits[:5]}")
|
|
debug(verbose, f"Total stable commits fetched: {len(stable_commits)}")
|
|
if not is_merged:
|
|
debug(verbose, f"Tag SHA not found in first {len(stable_commits)} commits of stable branch")
|
|
|
|
return is_merged
|
|
|
|
def is_release_candidate(version):
|
|
return "-rc" in version
|
|
|
|
def check_cmake_version(repo_url, branch, version_major, version_minor, github_token):
|
|
"""Verify the CMake version settings in src/CMakeLists.txt."""
|
|
cmake_file_path = "src/CMakeLists.txt"
|
|
content = get_branch_content(repo_url, branch, cmake_file_path, github_token)
|
|
if content is None:
|
|
print(f" ❌ Could not retrieve {cmake_file_path} from {branch}")
|
|
return False
|
|
|
|
expected_lines = [
|
|
f"set(LEAN_VERSION_MAJOR {version_major})",
|
|
f"set(LEAN_VERSION_MINOR {version_minor})",
|
|
f"set(LEAN_VERSION_PATCH 0)",
|
|
f"set(LEAN_VERSION_IS_RELEASE 1)"
|
|
]
|
|
|
|
for line in expected_lines:
|
|
if not any(l.strip().startswith(line) for l in content.splitlines()):
|
|
print(f" ❌ Missing or incorrect line in {cmake_file_path}: {line}")
|
|
return False
|
|
|
|
print(f" ✅ CMake version settings are correct in {cmake_file_path}")
|
|
return True
|
|
|
|
def extract_org_repo_from_url(repo_url):
|
|
"""Extract the 'org/repo' part from a GitHub URL."""
|
|
if repo_url.startswith("https://github.com/"):
|
|
return repo_url.replace("https://github.com/", "").rstrip("/")
|
|
return repo_url
|
|
|
|
def get_next_version(version):
|
|
"""Calculate the next version number, ignoring RC suffix."""
|
|
# Strip v prefix and RC suffix if present
|
|
base_version = strip_rc_suffix(version.lstrip('v'))
|
|
major, minor, patch = map(int, base_version.split('.'))
|
|
# Next version is always .0
|
|
return f"v{major}.{minor + 1}.0"
|
|
|
|
def check_bump_branch_toolchain(url, bump_branch, github_token):
|
|
"""Check if the lean-toolchain file in bump branch starts with either 'leanprover/lean4:nightly-' or the next version."""
|
|
content = get_branch_content(url, bump_branch, "lean-toolchain", github_token)
|
|
if content is None:
|
|
print(f" ❌ No lean-toolchain file found in {bump_branch} branch")
|
|
return False
|
|
|
|
# Extract the next version from the bump branch name (bump/v4.X.0)
|
|
next_version = bump_branch.split('/')[1]
|
|
|
|
if not (content.startswith("leanprover/lean4:nightly-") or
|
|
content.startswith(f"leanprover/lean4:{next_version}")):
|
|
print(f" ❌ Bump branch toolchain should use either nightly or {next_version}, but found: {content}")
|
|
return False
|
|
|
|
print(f" ✅ Bump branch correctly uses toolchain: {content}")
|
|
return True
|
|
|
|
def pr_exists_with_title(repo_url, title, github_token):
|
|
api_url = repo_url.replace("https://github.com/", "https://api.github.com/repos/") + "/pulls"
|
|
headers = {'Authorization': f'token {github_token}'} if github_token else {}
|
|
params = {'state': 'open'}
|
|
response = requests.get(api_url, headers=headers, params=params)
|
|
if response.status_code != 200:
|
|
return None
|
|
pull_requests = response.json()
|
|
for pr in pull_requests:
|
|
if pr['title'] == title:
|
|
return pr['number'], pr['html_url']
|
|
return None
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser(description="Check release status of Lean4 repositories")
|
|
parser.add_argument("toolchain", help="The toolchain version to check (e.g., v4.6.0)")
|
|
parser.add_argument("--verbose", "-v", action="store_true", help="Enable verbose debugging output")
|
|
parser.add_argument("--dry-run", action="store_true", help="Dry run mode (no actions taken)")
|
|
args = parser.parse_args()
|
|
|
|
github_token = get_github_token()
|
|
toolchain = args.toolchain
|
|
verbose = args.verbose
|
|
# dry_run = args.dry_run # Not used yet but available for future implementation
|
|
|
|
stripped_toolchain = strip_rc_suffix(toolchain)
|
|
lean_repo_url = "https://github.com/leanprover/lean4"
|
|
|
|
# Track repository status
|
|
repo_status = {} # Will store True for success, False for failure
|
|
|
|
# Preliminary checks for lean4 itself
|
|
print("\nPerforming preliminary checks...")
|
|
lean4_success = True
|
|
|
|
# Check for branch releases/v4.Y.0
|
|
version_major, version_minor, _ = map(int, stripped_toolchain.lstrip('v').split('.'))
|
|
branch_name = f"releases/v{version_major}.{version_minor}.0"
|
|
if not branch_exists(lean_repo_url, branch_name, github_token):
|
|
print(f" ❌ Branch {branch_name} does not exist")
|
|
lean4_success = False
|
|
else:
|
|
print(f" ✅ Branch {branch_name} exists")
|
|
# Check CMake version settings
|
|
if not check_cmake_version(lean_repo_url, branch_name, version_major, version_minor, github_token):
|
|
lean4_success = False
|
|
|
|
# Check for tag and release page
|
|
if not tag_exists(lean_repo_url, toolchain, github_token):
|
|
print(f" ❌ Tag {toolchain} does not exist.")
|
|
lean4_success = False
|
|
else:
|
|
print(f" ✅ Tag {toolchain} exists")
|
|
|
|
if not release_page_exists(lean_repo_url, toolchain, github_token):
|
|
print(f" ❌ Release page for {toolchain} does not exist")
|
|
lean4_success = False
|
|
else:
|
|
print(f" ✅ Release page for {toolchain} exists")
|
|
release_notes = get_release_notes(lean_repo_url, toolchain, github_token)
|
|
if not (release_notes and toolchain in release_notes.splitlines()[0].strip()):
|
|
previous_minor_version = version_minor - 1
|
|
previous_release = f"v{version_major}.{previous_minor_version}.0"
|
|
print(f" ❌ Release notes not published. Please run `script/release_notes.py --since {previous_release}` on branch `{branch_name}`.")
|
|
lean4_success = False
|
|
else:
|
|
print(f" ✅ Release notes look good.")
|
|
|
|
repo_status["lean4"] = lean4_success
|
|
|
|
# Load repositories and perform further checks
|
|
print("\nChecking repositories...")
|
|
|
|
with open(os.path.join(os.path.dirname(__file__), "release_repos.yml")) as f:
|
|
repos = yaml.safe_load(f)["repositories"]
|
|
|
|
for repo in repos:
|
|
name = repo["name"]
|
|
url = repo["url"]
|
|
org_repo = extract_org_repo_from_url(url)
|
|
branch = repo["branch"]
|
|
check_stable = repo["stable-branch"]
|
|
check_tag = repo.get("toolchain-tag", True)
|
|
check_bump = repo.get("bump-branch", False)
|
|
dependencies = repo.get("dependencies", [])
|
|
|
|
print(f"\nRepository: {name}")
|
|
|
|
# Check if any dependencies have failed
|
|
failed_deps = [dep for dep in dependencies if dep in repo_status and not repo_status[dep]]
|
|
if failed_deps:
|
|
print(f" 🟡 Dependencies not ready: {', '.join(failed_deps)}")
|
|
repo_status[name] = False
|
|
continue
|
|
|
|
# Initialize success flag for this repo
|
|
success = True
|
|
|
|
# Check if branch is on at least the target toolchain
|
|
lean_toolchain_content = get_branch_content(url, branch, "lean-toolchain", github_token)
|
|
if lean_toolchain_content is None:
|
|
print(f" ❌ No lean-toolchain file found in {branch} branch")
|
|
repo_status[name] = False
|
|
continue
|
|
|
|
on_target_toolchain = is_version_gte(lean_toolchain_content.strip(), toolchain)
|
|
if not on_target_toolchain:
|
|
print(f" ❌ Not on target toolchain (needs ≥ {toolchain}, but {branch} is on {lean_toolchain_content.strip()})")
|
|
pr_title = f"chore: bump toolchain to {toolchain}"
|
|
pr_info = pr_exists_with_title(url, pr_title, github_token)
|
|
if pr_info:
|
|
pr_number, pr_url = pr_info
|
|
print(f" ✅ PR with title '{pr_title}' exists: #{pr_number} ({pr_url})")
|
|
else:
|
|
print(f" ❌ PR with title '{pr_title}' does not exist")
|
|
print(f" Run `script/release_steps.py {toolchain} {name}` to create it")
|
|
repo_status[name] = False
|
|
continue
|
|
print(f" ✅ On compatible toolchain (>= {toolchain})")
|
|
|
|
if check_tag:
|
|
tag_exists_initially = tag_exists(url, toolchain, github_token)
|
|
if not tag_exists_initially:
|
|
if args.dry_run:
|
|
print(f" ❌ Tag {toolchain} does not exist. Run `script/push_repo_release_tag.py {org_repo} {branch} {toolchain}`.")
|
|
repo_status[name] = False
|
|
continue
|
|
else:
|
|
print(f" … Tag {toolchain} does not exist. Running `script/push_repo_release_tag.py {org_repo} {branch} {toolchain}`...")
|
|
|
|
# Run the script to create the tag
|
|
subprocess.run(["script/push_repo_release_tag.py", org_repo, branch, toolchain])
|
|
|
|
# Check again if the tag exists now
|
|
if not tag_exists(url, toolchain, github_token):
|
|
print(f" ❌ Manual intervention required.")
|
|
repo_status[name] = False
|
|
continue
|
|
|
|
# This will print in all successful cases - whether tag existed initially or was created successfully
|
|
print(f" ✅ Tag {toolchain} exists")
|
|
|
|
if check_stable and not is_release_candidate(toolchain):
|
|
if not is_merged_into_stable(url, toolchain, "stable", github_token, verbose):
|
|
org_repo = extract_org_repo_from_url(url)
|
|
print(f" ❌ Tag {toolchain} is not merged into stable")
|
|
print(f" Run `script/merge_remote.py {org_repo} stable {toolchain}` to merge it")
|
|
repo_status[name] = False
|
|
continue
|
|
print(f" ✅ Tag {toolchain} is merged into stable")
|
|
|
|
if check_bump:
|
|
next_version = get_next_version(toolchain)
|
|
bump_branch = f"bump/{next_version}"
|
|
if not branch_exists(url, bump_branch, github_token):
|
|
if args.dry_run:
|
|
print(f" ❌ Bump branch {bump_branch} does not exist. Run `gh api -X POST /repos/{org_repo}/git/refs -f ref=refs/heads/{bump_branch} -f sha=$(gh api /repos/{org_repo}/git/refs/heads/{branch} --jq .object.sha)` to create it.")
|
|
repo_status[name] = False
|
|
continue
|
|
print(f" … Bump branch {bump_branch} does not exist. Creating it...")
|
|
result = run_command(f"gh api -X POST /repos/{org_repo}/git/refs -f ref=refs/heads/{bump_branch} -f sha=$(gh api /repos/{org_repo}/git/refs/heads/{branch} --jq .object.sha)", check=False)
|
|
if result.returncode != 0:
|
|
print(f" ❌ Failed to create bump branch {bump_branch}")
|
|
repo_status[name] = False
|
|
continue
|
|
print(f" ✅ Bump branch {bump_branch} exists")
|
|
if not check_bump_branch_toolchain(url, bump_branch, github_token):
|
|
repo_status[name] = False
|
|
continue
|
|
|
|
repo_status[name] = success
|
|
|
|
# Final check for lean4 master branch
|
|
print("\nChecking lean4 master branch configuration...")
|
|
next_version = get_next_version(toolchain)
|
|
next_minor = int(next_version.split('.')[1])
|
|
|
|
cmake_content = get_branch_content(lean_repo_url, "master", "src/CMakeLists.txt", github_token)
|
|
if cmake_content is None:
|
|
print(" ❌ Could not retrieve CMakeLists.txt from master")
|
|
else:
|
|
cmake_lines = cmake_content.splitlines()
|
|
# Find the actual minor version in CMakeLists.txt
|
|
for line in cmake_lines:
|
|
if line.strip().startswith("set(LEAN_VERSION_MINOR "):
|
|
actual_minor = int(line.split()[-1].rstrip(")"))
|
|
version_minor_correct = actual_minor >= next_minor
|
|
break
|
|
else:
|
|
version_minor_correct = False
|
|
|
|
is_release_correct = any(
|
|
l.strip().startswith("set(LEAN_VERSION_IS_RELEASE 0)")
|
|
for l in cmake_lines
|
|
)
|
|
|
|
if not (version_minor_correct and is_release_correct):
|
|
print(" ❌ lean4 needs a \"begin dev cycle\" PR")
|
|
else:
|
|
print(" ✅ lean4 master branch is configured for next development cycle")
|
|
|
|
if __name__ == "__main__":
|
|
main()
|