e76bbef79b
This PR updates `simp? +suggestions` so that if a name is ambiguous (because of namespaces) all alternatives are used, rather than erroring.
86 lines
2.6 KiB
Text
86 lines
2.6 KiB
Text
import Lean.LibrarySuggestions
|
|
|
|
-- A custom function that simp doesn't know about
|
|
def myCustomAdd (x y : Nat) : Nat := x + y
|
|
|
|
-- A helper lemma about our custom function
|
|
theorem myCustomAdd_comm (x y : Nat) : myCustomAdd x y = myCustomAdd y x := by
|
|
simp [myCustomAdd, Nat.add_comm]
|
|
|
|
-- Set up a premise selector that suggests our helper theorem
|
|
set_library_suggestions (fun _ _ => pure #[{ name := `myCustomAdd_comm, score := 1.0 }])
|
|
|
|
-- Test that regular simp? fails without the premise
|
|
example (a b : Nat) : myCustomAdd a b = myCustomAdd b a := by
|
|
fail_if_success simp?
|
|
exact myCustomAdd_comm a b
|
|
|
|
-- Test that simp? +suggestions succeeds by using the selected premise
|
|
/--
|
|
info: Try this:
|
|
[apply] simp only [myCustomAdd_comm]
|
|
-/
|
|
#guard_msgs in
|
|
example (a b : Nat) : myCustomAdd a b = myCustomAdd b a := by
|
|
simp? +suggestions
|
|
|
|
-- Test that simp +suggestions (without ?) gives a helpful error
|
|
/--
|
|
error: +suggestions requires using simp? instead of simp
|
|
-/
|
|
#guard_msgs in
|
|
example (a b : Nat) : myCustomAdd a b = myCustomAdd b a := by
|
|
simp +suggestions
|
|
sorry
|
|
|
|
-- Test that simp_all? +suggestions works on the goal
|
|
/--
|
|
info: Try this:
|
|
[apply] simp_all only [myCustomAdd_comm]
|
|
-/
|
|
#guard_msgs in
|
|
example (a b : Nat) : myCustomAdd a b = myCustomAdd b a := by
|
|
simp_all? +suggestions
|
|
|
|
-- Test that simp_all? +suggestions works on a hypothesis
|
|
/--
|
|
info: Try this:
|
|
[apply] simp_all only [myCustomAdd_comm]
|
|
-/
|
|
#guard_msgs in
|
|
example (a b c : Nat) (h : myCustomAdd a b = c) : myCustomAdd b a = c := by
|
|
simp_all? +suggestions
|
|
|
|
-- Test that simp_all +suggestions (without ?) gives a helpful error
|
|
/--
|
|
error: +suggestions requires using simp_all? instead of simp_all
|
|
-/
|
|
#guard_msgs in
|
|
example (a b : Nat) (h : myCustomAdd a b = myCustomAdd b a) : myCustomAdd a b = myCustomAdd b a := by
|
|
simp_all +suggestions
|
|
sorry
|
|
|
|
-- Test ambiguous lemmas with DIFFERENT statements that are both needed
|
|
-- Root version: left identity
|
|
theorem myCustomAdd_id (x : Nat) : myCustomAdd 0 x = x := by
|
|
simp [myCustomAdd]
|
|
|
|
-- Foo version: right identity
|
|
theorem Foo.myCustomAdd_id (x : Nat) : myCustomAdd x 0 = x := by
|
|
simp [myCustomAdd]
|
|
|
|
-- Set up premise selector that suggests the ambiguous name
|
|
set_library_suggestions (fun _ _ => pure #[{ name := `myCustomAdd_id, score := 1.0 }])
|
|
|
|
open Foo
|
|
|
|
-- This goal needs BOTH lemmas to solve:
|
|
-- myCustomAdd 0 a simplifies to a (using root version)
|
|
-- myCustomAdd b 0 simplifies to b (using Foo version)
|
|
/--
|
|
info: Try this:
|
|
[apply] simp_all only [_root_.myCustomAdd_id, Foo.myCustomAdd_id]
|
|
-/
|
|
#guard_msgs in
|
|
example (a b : Nat) (h : myCustomAdd 0 a = myCustomAdd b 0) : a = b := by
|
|
simp_all? +suggestions
|