5cef84709f
See Section "Other goodies" at https://github.com/leanprover/lean/wiki/Refactoring-structures This commit also improves the support for projections in the unifier/matcher. Now, we consider the extra case-split for projections. Given a projection `proj`, and the constraint `proj s =?= proj t`, we need to try first `s =?= t` and if it fails, then try to reduce. This is needed in the standard library because we now have constraints such as: ``` @has_le.le ?A ?s ?a ?b =?= @has_le.le nat nat.has_add x y ``` If we reduce the right hand side, we get the unsolvable constraint ``` @has_le.le ?A ?s ?a ?b =?= nat.le x y ``` Before this change, the constraint was `@le ?A ?s ?a ?b =?= @le nat nat.has_add x y`, and we already perform a case-split in this case. Moreover, projections were eagerly reduced whenever possible. The extra case-split generates a performance problem in several tests. For example `fib 8 = 34` was timing out. I worked around this issue by performing the case-split only when the constraint contains meta-variables. There are also minor issues. Example. `<` is notation for `has_lt.lt`, but `>` is for `gt`.
7 lines
580 B
Text
7 lines
580 B
Text
rquote.lean:14:7: error: invalid resolved quoted symbol, it is ambiguous, possible interpretations: boo.f foo.f (solution: use fully qualified names)
|
|
name.mk_string "g" (name.mk_string "foo" name.anonymous) : name
|
|
name.mk_string "add" (name.mk_string "has_add" name.anonymous) : name
|
|
name.mk_string "gcd" (name.mk_string "nat" name.anonymous) : name
|
|
name.mk_string "f" name.anonymous : name
|
|
name.mk_string "f" (name.mk_string "foo" name.anonymous) : name
|
|
rquote.lean:32:9: error: invalid quoted symbol, failed to resolve it (solution: use `<identifier> to bypass name resolution)
|