This PR fixes a bug where `grind?` suggestions would not include parameters using local variable dot notation (e.g., `cs.getD_rightInvSeq` where `cs` is a local variable). These parameters were incorrectly filtered out because the code assumed all ident params resolve to global declarations. In fact, local variable dot notation produces anchors that need the original term to be loaded during replay, so they must be preserved in the suggestion. Closes #12185 🤖 Prepared with Claude Code Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
32 lines
1.2 KiB
Text
32 lines
1.2 KiB
Text
/-!
|
|
# Test that `grind?` includes local variable dot notation params in its suggestion
|
|
|
|
When a user provides a parameter like `s.myThm` where `s` is a local variable
|
|
and `myThm` is a field access, it should be included in the suggestion.
|
|
These params are processed as term params (not global decls) and produce anchors.
|
|
Without including the original term in the suggestion, the anchor can't match on replay.
|
|
|
|
Regression test for: grind? suggestions not working with local variable dot notation
|
|
-/
|
|
set_option linter.unusedVariables false
|
|
|
|
structure MyStruct where
|
|
val : Nat
|
|
|
|
-- A theorem with an indexable pattern
|
|
theorem MyStruct.add_comm (s : MyStruct) (a b : Nat) : a + b = b + a := Nat.add_comm a b
|
|
|
|
-- Test: Local variable dot notation should be included in the suggestion
|
|
-- `s.add_comm` is a local variable dot notation (not a global decl),
|
|
-- so it should appear in the grind only suggestion
|
|
/--
|
|
info: Try this:
|
|
[apply] grind only [= s.add_comm]
|
|
-/
|
|
#guard_msgs in
|
|
example (s : MyStruct) : (1 : Nat) + 2 = 2 + 1 := by
|
|
grind? [= s.add_comm]
|
|
|
|
-- Verify the suggestion works by using it
|
|
example (s : MyStruct) : (1 : Nat) + 2 = 2 + 1 := by
|
|
grind only [= s.add_comm]
|