24cb133eb2
This PR introduces an explicit `defeq` attribute to mark theorems that can be used by `dsimp`. The benefit of an explicit attribute over the prior logic of looking at the proof body is that we can reliably omit theorem bodies across module boundaries. It also helps with intra-file parallelism. If a theorem is syntactically defined by `:= rfl`, then the attribute is assumed and need not given explicitly. This is a purely syntactic check and can be fooled, e.g. if in the current namespace, `rfl` is not actually “the” `rfl` of `Eq`. In that case, some other syntax has be used, such as `:= (rfl)`. This is also the way to go if a theorem can be proved by `defeq`, but one does not actually want `dsimp` to use this fact. The `defeq` attribute will look at the *type* of the declaration, not the body, to check if it really holds definitionally. Because of different reduction settings, this can sometimes go wrong. Then one should also write `:= (rfl)`, if one does not want this to be a defeq theorem. (If one does then this is currently not possible, but it’s probably a bad idea anyways). The `set_option debug.tactic.simp.checkDefEqAttr true`, `dsimp` will warn if could not apply a lemma due to a missing `defeq` attribute. With `set_option backward.dsimp.useDefEqAttr.get false` one can revert to the old behavior of inferring rfl-ness based on the theorem body. Both options will go away eventually (too bad we can’t mark them as deprecated right away, see #7969) Meta programs that generate theorems (e.g. equational theorems) can use `inferDefEqAttr` to set the attribute based on the theorem body of the just created declaration. This builds on #8501 to update Init to `@[expose]` a fair amount of definitions that, if not exposed, would prevent some existing `:= rfl` theorems from being `defeq` theorems. In the interest of starting backwards compatible, I exposed these function. Hopefully many can be un-exposed later again. A mathlib adaption branch exists that includes both the meta programming fixes and changes to the theorems (e.g. changing `:= by rfl` to `:= rfl`). With the module system there is now no special handling for `defeq` theorem bodies, because we don’t look at the body anymore. The previous hack is removed. The `defeq`-ness of the theorem needs to be checked in the context of the theorem’s *type*; the error message contains a hint if the defeq check fails because of the exported context.
52 lines
1.7 KiB
Text
52 lines
1.7 KiB
Text
/-! # `dsimp` uses theorems whose proofs are unapplied constants
|
|
|
|
This test ensures that `dsimp` can take advantage of `@[simp]` theorems whose proofs are unapplied
|
|
constants which are marked as `rfl` theorems.
|
|
|
|
## Context
|
|
|
|
To determine if a `@[simp]` theorem is a `rfl` theorem (and therefore usable by `dsimp`), we check
|
|
if its proof is one of the following:
|
|
|
|
1. directly a `rfl` proof, e.g. `Eq.rfl`
|
|
2. a `symm` proof of `rfl` proofs
|
|
3. an application of a constant which is considered a `rfl` theorem
|
|
|
|
This means that a theorem `foo` whose proofs is of the form `foo_internal_with_arg 0` where
|
|
`foo_internal_with_arg` is a `rfl` theorem. The first section
|
|
demonstrates that behavior as a control case.
|
|
|
|
We also want to consider a theorem a `rfl` theorem if its proof is simply:
|
|
|
|
4. a constant which is a `rfl` theorem
|
|
|
|
and is not necessarily applied to any arguments.
|
|
|
|
This behavior is ensured by the test case in the second section.
|
|
|
|
See issue #2685.
|
|
-/
|
|
|
|
/-- A wrapper which `dsimp` will eliminate after an appropriate `@[simp]` theorem is added. -/
|
|
def w : Bool → Bool | b => b
|
|
|
|
/-! # Control: `dsimp` uses applied constants -/
|
|
|
|
-- Check that `dsimp` makes no progress before we add the `@[simp]` theorem
|
|
example : w true = true := by dsimp
|
|
|
|
theorem foo_internal_with_arg (_ : Nat) : w true = true := rfl
|
|
@[simp, defeq] theorem foo_using_arg : w true = true := foo_internal_with_arg 0
|
|
|
|
example : w true = true := by dsimp
|
|
|
|
|
|
/-! # Test: `dsimp` uses unapplied constants -/
|
|
|
|
-- Check that `dsimp` makes no progress before we add the `@[simp]` theorem
|
|
example : w false = false := by dsimp
|
|
|
|
theorem foo_internal_without_arg : w false = false := rfl
|
|
@[simp, defeq] theorem foo_without_arg : w false = false := foo_internal_without_arg
|
|
|
|
example : w false = false := by dsimp
|