f180eee7bf
This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
17 lines
1.3 KiB
Text
17 lines
1.3 KiB
Text
termination_by.lean:9:2-9:18: warning: unused `termination_by`, function is not recursive
|
|
termination_by.lean:12:2-12:21: warning: unused `decreasing_by`, function is not recursive
|
|
termination_by.lean:15:2-16:21: warning: unused termination hints, function is not recursive
|
|
termination_by.lean:19:2-19:18: warning: unused `termination_by`, function is partial
|
|
termination_by.lean:22:2-22:21: warning: unused `decreasing_by`, function is partial
|
|
termination_by.lean:25:2-26:21: warning: unused termination hints, function is partial
|
|
termination_by.lean:29:0-29:16: warning: unused `termination_by`, function is unsafe
|
|
termination_by.lean:32:2-32:21: warning: unused `decreasing_by`, function is unsafe
|
|
termination_by.lean:35:2-36:21: warning: unused termination hints, function is unsafe
|
|
termination_by.lean:40:4-40:20: warning: unused `termination_by`, function is not recursive
|
|
termination_by.lean:44:4-44:20: warning: unused `termination_by`, function is not recursive
|
|
termination_by.lean:54:2-54:18: warning: unused `termination_by`, function is not recursive
|
|
termination_by.lean:62:2-62:23: error: incomplete set of termination hints:
|
|
This function is mutually recursive with isOdd, which does not have a termination hint.
|
|
The present clause is ignored.
|
|
Try this:
|
|
termination_by x1 => x1
|