This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
34 lines
1 KiB
Text
34 lines
1 KiB
Text
def Set := Nat → Prop
|
|
|
|
namespace Set
|
|
|
|
def singleton (a : Nat) : Set := fun b ↦ b = a
|
|
|
|
def compl (s : Set) : Set := fun x ↦ ¬ s x
|
|
|
|
@[simp]
|
|
theorem compl_iff (s : Set) (x : Nat) : s.compl x ↔ ¬ s x := Iff.rfl
|
|
|
|
@[simp]
|
|
theorem singleton_iff {a b : Nat} : singleton b a ↔ a = b := Iff.rfl
|
|
|
|
open Classical
|
|
|
|
noncomputable def indicator (s : Set) (x : Nat) : Nat := if s x then 1 else 0
|
|
|
|
@[simp] -- remove `simp` attribute --> works (and the trace changes)
|
|
theorem indicator_of {s : Set} {a : Nat} (h : s a) : indicator s a = 1 := if_pos h
|
|
|
|
@[simp]
|
|
theorem indicator_of_not {s : Set} {a : Nat} (h : ¬ s a) : indicator s a = 0 := if_neg h
|
|
|
|
/--
|
|
info: Try this:
|
|
simp only [compl_iff, singleton_iff, not_true_eq_false, not_false_eq_true, indicator_of_not]
|
|
-/
|
|
#guard_msgs in
|
|
theorem test : indicator (compl <| singleton 0) 0 = 0 := by
|
|
simp? -- should not leave out `singleton_iff`
|
|
|
|
theorem test' : indicator (compl <| singleton 0) 0 = 0 := by
|
|
simp only [compl_iff, singleton_iff, not_true_eq_false, not_false_eq_true, indicator_of_not]
|