f180eee7bf
This PR adjusts the "try this" widget to be rendered as a widget message under 'Messages', not a separate widget under a 'Suggestions' section. The main benefit of this is that the message of the widget is not duplicated between 'Messages' and 'Suggestions'. Since widget message suggestions were already implemented by @jrr6 for the new hint infrastructure, this PR replaces the old "try this" implementation with the new hint infrastructure. In doing so, the `style?` field of suggestions is deprecated, since the hint infrastructure highlights hints using diff colors, and `style?` also never saw much use downstream. Additionally, since the message and the suggestion are now the same component, the `messageData?` field of suggestions is deprecated as well. Notably, the "Try this:" message string now also contains a newline and indentation to separate the suggestion from the rest of the message more clearly and the `postInfo?` field of the suggestion is now part of the message. Finally, this PR changes the diff colors used by the hint infrastructure to be more color-blindness-friendly (insertions are now blue, not green, and text that remains unchanged is now using the editor foreground color instead of blue). ### Breaking changes Tests that use `#guard_msgs` to test the "Try this:" message may need to be adjusted for the new formatting of the message.
28 lines
525 B
Text
28 lines
525 B
Text
/-!
|
|
# `simp?`-suggested names conflicting with auxiliary declarations
|
|
|
|
https://github.com/leanprover/lean4/issues/6706
|
|
|
|
This test ensures that "unresolved" names provided by `simp?` do not conflict with local auxiliary
|
|
declarations.
|
|
-/
|
|
|
|
def P := True
|
|
theorem N.A.B : P := trivial
|
|
/--
|
|
info: Try this:
|
|
simp only [N.A.B]
|
|
-/
|
|
#guard_msgs in
|
|
theorem N.X.A.B : P := by
|
|
simp? [N.A.B]
|
|
|
|
/--
|
|
info: Try this:
|
|
simp only [_root_.N.A.B]
|
|
-/
|
|
#guard_msgs in
|
|
theorem A : P :=
|
|
let rec N.A.B := ()
|
|
by simp? [_root_.N.A.B]
|
|
where B := ()
|