26dba92ce9
This PR significantly improves the performance of auto-completion by optimizing individual requests by a factor of ~2 and by giving language clients like VS Code the opportunity to reuse the state of previous completion requests, thus greatly reducing the latency for the auto-completion list to update when adding more characters to an identifier. In my testing: - The latency of completing `C` in a file with `import Mathlib` was reduced from ~1650ms to ~800ms - The latency of completing `Cat` in a file with `import Mathlib` was reduced from ~800ms to ~430ms - The latency of completing dot notation was mostly unaffected - Successive completions are now practically instant, e.g. if we were to complete `C` and then type it out to `Cat`, before it would take roughly ~1650ms + ~800ms, whereas now there is only a significant latency for completing `C` (~800ms) and the completion list is updated practically instantly when typing out `Cat`. <details> <summary>(Video) Auto-completion latency before this PR</summary>  </details> <details> <summary>(Video) Auto-completion latency after this PR</summary>  </details> In detail, this PR makes the following changes: - Set `isIncomplete` to `false` in non-synthetic completion responses so that the client can re-use these completion states. - Replace the server side fuzzy matching with a simple and fast check that all characters in the identifier thus far are present in the same order in the declaration to match against. There are some examples where the simple and fast check yields a completion item that the fuzzy matching would filter, but since VS Code filters the completion items with its own fuzzy matching after that anyways, these extra completion items are never actually displayed to the user. - Remove all notions of scoring and sorting completion items from the language server. We now rely entirely on the client to sort the completion items as it sees fit. In my testing, the only significant change as a result of this is that while the language server would sometimes penalize namespaces with lots of components, VS Code instead uses a strictly alphabetic order. Even before this change, we never actually really prioritized local variables over global variables, so the penalty wasn't very helpful in practice. We might add some small form of local variable prioritization in the future, though. - Remove the empty completion list hack that was introduced in #1885. It does not appear to be necessary anymore.
20 lines
686 B
Text
20 lines
686 B
Text
{"textDocument": {"uri": "file:///completionCheck.lean"},
|
|
"position": {"line": 6, "character": 33}}
|
|
{"items":
|
|
[{"label": "AVerySpecificStructureName2",
|
|
"kind": 22,
|
|
"data":
|
|
{"params":
|
|
{"textDocument": {"uri": "file:///completionCheck.lean"},
|
|
"position": {"line": 6, "character": 33}},
|
|
"id": {"const": {"declName": "AVerySpecificStructureName2"}},
|
|
"cPos": 0}},
|
|
{"label": "AVerySpecificStructureName",
|
|
"kind": 22,
|
|
"data":
|
|
{"params":
|
|
{"textDocument": {"uri": "file:///completionCheck.lean"},
|
|
"position": {"line": 6, "character": 33}},
|
|
"id": {"const": {"declName": "AVerySpecificStructureName"}},
|
|
"cPos": 0}}],
|
|
"isIncomplete": false}
|