29298c9f30
This PR allows `simp` to recognize and warn about simp lemmas that are likely looping in the current simp set. It does so automatically whenever simplification fails with the dreaded “max recursion depth” error fails, but it can be made to do it always with `set_option linter.loopingSimpArgs true`. This check is not on by default because it is somewhat costly, and can warn about simp calls that still happen to work. This closes #5111. In the end, this implemented much simpler logic than described there (and tried in the abandoned #8688; see that PR description for more background information), but it didn’t work as well as I thought. The current logic is: “Simplify the RHS of the simp theorem, complain if that fails”. It is a reasonable policy for a Lean project to say that all simp invocation should be so that this linter does not complain. Often it is just a matter of explicitly disabling some simp theorems from the default simp set, to make it clear and robust that in this call, we do not want them to trigger. But given that often such simp call happen to work, it’s too pedantic to impose it on everyone.
37 lines
1,000 B
Text
37 lines
1,000 B
Text
set_option linter.unusedSimpArgs false
|
||
|
||
variable (n v₁ v₂) (hv₁: v₁ < n + 1) (hv₂: v₂ < n + 1)
|
||
|
||
theorem foo (_: ¬ Fin.mk v₂ hv₂ = Fin.mk v₁ hv₁ ): True := trivial
|
||
|
||
/--
|
||
trace: [Meta.Tactic.simp.unify] eq_self:1000, failed to unify
|
||
?a = ?a
|
||
with
|
||
⟨v₂, hv₂⟩ = ⟨v₁, hv₁⟩
|
||
[Meta.Tactic.simp.rewrite] Fin.mk.injEq:1000:
|
||
⟨v₂, hv₂⟩ = ⟨v₁, hv₁⟩
|
||
==>
|
||
v₂ = v₁
|
||
[Meta.Tactic.simp.unify] eq_self:1000, failed to unify
|
||
?a = ?a
|
||
with
|
||
v₂ = v₁
|
||
[Meta.Tactic.simp.discharge] Nat.ne_of_gt discharge ✅️
|
||
v₁ < v₂
|
||
[Meta.Tactic.simp.rewrite] hv:1000:
|
||
v₁ < v₂
|
||
==>
|
||
True
|
||
[Meta.Tactic.simp.rewrite] Nat.ne_of_gt:1000:
|
||
v₂ = v₁
|
||
==>
|
||
False
|
||
-/
|
||
#guard_msgs in
|
||
set_option trace.Meta.Tactic.simp true in
|
||
example (hv: v₁ < v₂) : True :=
|
||
foo n v₁ v₂ ‹_› ‹_›
|
||
(by simp +decide only [hv, Fin.mk.injEq, Nat.ne_of_gt, Nat.lt_succ_iff])
|
||
|
||
#check Fin.mk.injEq
|